Messages in this thread | | | Date | Sat, 27 Feb 2021 11:00:01 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH] i2c/busses: fix spellint typo |
| |
Hi zuoqilin,
There's an obvious typo in the subject. Which is kind of ironical considering the point of your patch.
Also, your patch is driver-specific, so "i2c/busses:" isn't an appropriate prefix. According to the standard practice for the i2c subsystem, the proper prefix for the subject would be: "i2c: sis630:".
On Thu, 25 Feb 2021 19:53:38 +0800, zuoqilin1@163.com wrote: > From: zuoqilin <zuoqilin@yulong.com> > > change 'adress' to 'address'
Please start your sentences with a capital and end them with a dot.
> > Signed-off-by: zuoqilin <zuoqilin@yulong.com> > --- > drivers/i2c/busses/i2c-sis630.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c > index cfb8e04..87d5625 100644 > --- a/drivers/i2c/busses/i2c-sis630.c > +++ b/drivers/i2c/busses/i2c-sis630.c > @@ -97,7 +97,7 @@ > module_param(force, bool, 0); > MODULE_PARM_DESC(force, "Forcibly enable the SIS630. DANGEROUS!"); > > -/* SMBus base adress */ > +/* SMBus base address */ > static unsigned short smbus_base; > > /* supported chips */
Other than that, the change looks OK, thanks.
-- Jean Delvare SUSE L3 Support
| |