Messages in this thread | | | From | Jagan Teki <> | Date | Fri, 26 Feb 2021 21:57:07 +0530 | Subject | Re: [PATCH v2 02/10] ARM: dts: stm32: Add Engicam MicroGEA STM32MP1 SoM |
| |
Hi Alexandre,
On Fri, Feb 26, 2021 at 9:42 PM Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: > > Hi Jagan > > On 2/26/21 8:02 AM, Jagan Teki wrote: > > MicroGEA STM32MP1 is an EDIMM SoM based on STM32MP157A from Engicam. > > > > General features: > > - STM32MP157AAC > > - Up to 1GB DDR3L-800 > > - 512MB Nand flash > > - I2S > > > > MicroGEA STM32MP1 needs to mount on top of Engicam MicroDev carrier > > boards for creating complete platform solutions. > > > > Add support for it. > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > Signed-off-by: Francesco Utel <francesco.utel@engicam.com> > > Signed-off-by: Mirko Ardinghi <mirko.ardinghi@engicam.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Minor question: if the stm32mp157 is soldered on Microdev boards why do > you mention it in this commit message ?
It was there in the commit message:
> > General features: > > - STM32MP157AAC > > - Up to 1GB DDR3L-800 > > - 512MB Nand flash > > - I2S
> > + a minor comment bellow. > > thanks > Alex > > > --- > > Changes for v2: > > - none > > > > .../dts/stm32mp157a-microgea-stm32mp1.dtsi | 147 ++++++++++++++++++ > > 1 file changed, 147 insertions(+) > > create mode 100644 arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi > > > > diff --git a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi > > new file mode 100644 > > index 000000000000..97d569107bfe > > --- /dev/null > > +++ b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi > > @@ -0,0 +1,147 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > > +/* > > + * Copyright (c) STMicroelectronics 2019 - All Rights Reserved > > + * Copyright (c) 2020 Engicam srl > > + * Copyright (c) 2020 Amarula Solutons(India) > > + */ > > + > > +/ { > > + compatible = "engicam,microgea-stm32mp1", "st,stm32mp157"; > > + > > + memory@c0000000 { > > you could add device_type = "memory";
Okay.
Jagan.
| |