lkml.org 
[lkml]   [2021]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf vendor events: Remove 'type' field from mapfiles
From
Date
On 26/02/2021 15:47, Andi Kleen wrote:
> On Fri, Feb 26, 2021 at 09:08:17PM +0800, John Garry wrote:
>> Included for each CPU entry in the per-arch mapfile.csv file is a 'type'
>> field.
> I don't like it because this will make the mapfile incompatible with
> what download.01.org uses. We originally derived it from that.

I assumed that it was this file:
https://download.01.org/perfmon/mapfile.csv

which already has a different format - extra columns - so figured that
some handcrafting was already going on. Indeed 'type' is not always
'core' there.

>
> It would be ok if it fixed something serious, but as it seems to be
> more cosmetic I don't think there's a good reason to devivate.
>

If you're against that, then ok; I suppose jevents handling could still
be removed, but I'm not enthused.

Thanks,
John


\
 
 \ /
  Last update: 2021-02-26 17:20    [W:0.056 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site