lkml.org 
[lkml]   [2021]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ia64: Depend on non-static printk for cmpxchg debug
Matthew Wilcox writes:
>Why not just fix it?
>
>diff --git a/arch/ia64/include/uapi/asm/cmpxchg.h b/arch/ia64/include/uapi/asm/cmpxchg.h
>index 5d90307fd6e0..d955a8e3ebde 100644
>--- a/arch/ia64/include/uapi/asm/cmpxchg.h
>+++ b/arch/ia64/include/uapi/asm/cmpxchg.h
>@@ -139,7 +139,7 @@ extern long ia64_cmpxchg_called_with_bad_pointer(void);
> do { \
> if (_cmpxchg_bugcheck_count-- <= 0) { \
> void *ip; \
>- extern int printk(const char *fmt, ...); \
>+ int printk(const char *fmt, ...); \
> ip = (void *) ia64_getreg(_IA64_REG_IP); \
> printk("CMPXCHG_BUGCHECK: stuck at %p on word %p\n", ip, (v));\
> break; \

I must confess I have no idea of the history of why it was `extern int` in the
first place -- my fear was somehow we use cmpxchg.h from a different context.
Do you have any idea? :-)

\
 
 \ /
  Last update: 2021-02-26 14:17    [W:0.043 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site