Messages in this thread | | | Date | Fri, 26 Feb 2021 09:13:27 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: mark some mpspec inline functions as __init |
| |
On Thu, Feb 25, 2021 at 01:58:48PM -0800, Nick Desaulniers wrote: > The config that reproduces it wasn't shared here; I wouldn't be > surprised if this was found via randconfig that enabled some config > that led to excessive code bloat somewhere somehow.
I'm sceptical it is the .config. As I said, those single function calls which I could replace by hand - the wrappers simply make the code cleaner. They could just as well be macros FWIW and then the inlining will be practically forced at preprocess time.
> Oh, I don't expect everyone to; just leaving breadcrumbs showing other > people on thread how to fish. ;)
Yap, that's appreciated.
> Sure, it doesn't really matter to me which way this is fixed. I > personally prefer placing functions in the correct sections and > letting the compiler be flexible, since if all of this is to satisfy > some randconfig then __always_inline is making a decision for all > configs, but perhaps it doesn't matter.
I hope.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |