Messages in this thread | | | Subject | Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload | From | Alex Elder <> | Date | Thu, 25 Feb 2021 09:29:16 -0600 |
| |
On 2/24/21 12:23 PM, Jakub Kicinski wrote: > On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote: >> +/* MAP CSUM headers */ >> +struct rmnet_map_v5_csum_header { >> +#if defined(__LITTLE_ENDIAN_BITFIELD) >> + u8 next_hdr:1; >> + u8 header_type:7; >> + u8 hw_reserved:7; >> + u8 csum_valid_required:1; >> +#elif defined(__BIG_ENDIAN_BITFIELD) >> + u8 header_type:7; >> + u8 next_hdr:1; >> + u8 csum_valid_required:1; >> + u8 hw_reserved:7; >> +#else >> +#error "Please fix <asm/byteorder.h>" >> +#endif >> + __be16 reserved; >> +} __aligned(1); > > This seems to be your first contribution so let me spell it out. > > In Linux when maintainers ask you to do something you are expected > to do it. > > You can leave the existing bitfields for later, but don't add another.
As I offered, I will implement changes to the existing code to use masks in place of these C bit-fields.
I will try complete this within the next week. If it looks good it could serve as an example of how to go about it.
-Alex
| |