lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] nfsd: fix kconfig dependency warning for NFSD_V4
Date
Hi Julian-

> On Feb 19, 2021, at 4:56 PM, Julian Braha <julianbraha@gmail.com> wrote:
>
> When NFSD_V4 is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA256
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]
>
> WARNING: unmet direct dependencies detected for CRYPTO_MD5
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]
>
> This is because NFSD_V4 selects CRYPTO_MD5 and CRYPTO_SHA256,
> without depending on or selecting CRYPTO, despite those config options
> being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

I've included this patch in the for-rc topic branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

However, there was some harumphing over on linux-rdma about
a similar change for CRYPTO_CRC32 and the rxe driver. I'm
not quite clear about the outcome of that conversation. It
seems like we are going with either

- add "select CRYPTO"

or

- add "depends on CRYPTO"


> --- a/fs/nfsd/Kconfig 2021-02-09 22:05:29.462030761 -0500
> +++ b/fs/nfsd/Kconfig 2021-02-11 12:00:48.974076992 -0500
> @@ -73,6 +73,7 @@
> select NFSD_V3
> select FS_POSIX_ACL
> select SUNRPC_GSS
> + select CRYPTO
> select CRYPTO_MD5
> select CRYPTO_SHA256
> select GRACE_PERIOD
>
>

--
Chuck Lever



\
 
 \ /
  Last update: 2021-02-24 22:12    [W:0.033 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site