Messages in this thread | | | Date | Wed, 24 Feb 2021 08:38:05 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC |
| |
Hi Álvaro,
Álvaro Fernández Rojas <noltari@gmail.com> wrote on Wed, 24 Feb 2021 08:16:58 +0100:
> Hi Florian, > > > El 24 feb 2021, a las 4:46, Florian Fainelli <f.fainelli@gmail.com> escribió: > > > > > > > > On 2/22/2021 12:16 PM, Álvaro Fernández Rojas wrote: > >> Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall > >> always be done without ECC enabled. > >> This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2 > >> clenmarkers are added to the OOB with ECC enabled, OOB bytes will be changed > >> from ff ff ff to 00 00 00, reporting incorrect ECC errors. > >> > >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > > > > Should there be a Fixes: tag provided here for back porting to stable trees? > > I think so, but the fixed commit would be the first one, right? > 27c5b17cd1b10564fa36f8f51e4b4b41436ecc32
Yep, shouldn't be a problem.
Thanks, Miquèl
| |