Messages in this thread | | | Date | Wed, 24 Feb 2021 08:30:35 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers: staging: comedi: Fixed side effects from macro definition. |
| |
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
A: No. Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Wed, Feb 24, 2021 at 12:47:26PM +0530, chakravarthi Kulkarni wrote: > Hi, > > I tested it will unit test cases it looks fine. > int x = 10; > NI_USUAL_PFI_SELECT(x++) > > will not have side effects as it is taken care using local variable in > macro.
You ignored what Ian said about why this change was not ok :(
It's long deleted from my review queue, sorry.
greg k-h
| |