lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/7 v4] sched/fair: remove unused parameter of update_nohz_stats
    Date
    idle load balance is the only user of update_nohz_stats and doesn't use
    force parameter. Remove it

    Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
    ---
    kernel/sched/fair.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index e23709f6854b..f52f4dd3fb9e 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -8352,7 +8352,7 @@ group_type group_classify(unsigned int imbalance_pct,
    return group_has_spare;
    }

    -static bool update_nohz_stats(struct rq *rq, bool force)
    +static bool update_nohz_stats(struct rq *rq)
    {
    #ifdef CONFIG_NO_HZ_COMMON
    unsigned int cpu = rq->cpu;
    @@ -8363,7 +8363,7 @@ static bool update_nohz_stats(struct rq *rq, bool force)
    if (!cpumask_test_cpu(cpu, nohz.idle_cpus_mask))
    return false;

    - if (!force && !time_after(jiffies, rq->last_blocked_load_update_tick))
    + if (!time_after(jiffies, rq->last_blocked_load_update_tick))
    return true;

    update_blocked_averages(cpu);
    @@ -10401,7 +10401,7 @@ static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,

    rq = cpu_rq(balance_cpu);

    - has_blocked_load |= update_nohz_stats(rq, true);
    + has_blocked_load |= update_nohz_stats(rq);

    /*
    * If time for next balance is due,
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-02-24 16:11    [W:2.889 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site