lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 10/26] staging: most: sound: add sanity check for function argument
    Date
    From: Christian Gromm <christian.gromm@microchip.com>

    [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ]

    This patch checks the function parameter 'bytes' before doing the
    subtraction to prevent memory corruption.

    Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/1612282865-21846-1-git-send-email-christian.gromm@microchip.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/most/sound/sound.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
    index 89b02fc305b8b..fd9245d7eeb9a 100644
    --- a/drivers/staging/most/sound/sound.c
    +++ b/drivers/staging/most/sound/sound.c
    @@ -86,6 +86,8 @@ static void swap_copy24(u8 *dest, const u8 *source, unsigned int bytes)
    {
    unsigned int i = 0;

    + if (bytes < 2)
    + return;
    while (i < bytes - 2) {
    dest[i] = source[i + 2];
    dest[i + 1] = source[i + 1];
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-02-24 15:40    [W:2.903 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site