Messages in this thread | | | Date | Wed, 24 Feb 2021 09:29:54 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer |
| |
Hi!
> >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > >>@@ -42,6 +42,8 @@ static char *macaddr; > >> module_param(macaddr, charp, 0); > >> MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); > >> > >>+u8 macaddr_buf[ETH_ALEN]; > >>+ > > > >Should this be static? > > Yes, there is already a patch [1] queued by Michael but not yet upstream. > When it will be merged upstream I will make sure it will be backported.
Having it in mainline is enough, I don't really think it causes anything user-visible, so it does not need to be in stable.
Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |