lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V3 5/5] mmc: sdhci-esdhc-imx: validate pinctrl before use it
    Date
    From: Peng Fan <peng.fan@nxp.com>

    When imx_data->pinctrl is not a valid pointer, pinctrl_lookup_state
    will trigger kernel panic.

    When we boot Dual OS on Jailhouse hypervisor, we let the 1st Linux to
    configure pinmux ready for the 2nd OS, so the 2nd OS not have pinctrl
    settings.

    Similar to this commit b62eee9f804e ("mmc: sdhci-esdhc-imx: no fail when no pinctrl available").

    Reviewed-by: Bough Chen <haobo.chen@nxp.com>
    Reviewed-by: Alice Guo <alice.guo@nxp.com>
    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    ---
    drivers/mmc/host/sdhci-esdhc-imx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
    index a20459744d21..94327988da91 100644
    --- a/drivers/mmc/host/sdhci-esdhc-imx.c
    +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
    @@ -1488,7 +1488,7 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,

    mmc_of_parse_voltage(np, &host->ocr_mask);

    - if (esdhc_is_usdhc(imx_data)) {
    + if (esdhc_is_usdhc(imx_data) && !IS_ERR(imx_data->pinctrl)) {
    imx_data->pins_100mhz = pinctrl_lookup_state(imx_data->pinctrl,
    ESDHC_PINCTRL_STATE_100MHZ);
    imx_data->pins_200mhz = pinctrl_lookup_state(imx_data->pinctrl,
    --
    2.30.0
    \
     
     \ /
      Last update: 2021-02-25 04:25    [W:4.770 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site