Messages in this thread | | | Date | Mon, 22 Feb 2021 07:52:34 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 0/4] mm/gup: page unpining improvements |
| |
On Thu, Feb 18, 2021 at 03:33:39PM +0000, Joao Martins wrote: > in a bvec at once? e.g. something like from this: > > bio_for_each_segment_all(bvec, bio, iter_all) { > if (mark_dirty && !PageCompound(bvec->bv_page)) > set_page_dirty_lock(bvec->bv_page); > put_page(bvec->bv_page); > } > > (...) to this instead: > > bio_for_each_bvec_all(bvec, bio, i) > unpin_user_page_range_dirty_lock(bvec->bv_page, > DIV_ROUND_UP(bvec->bv_len, PAGE_SIZE), > mark_dirty && !PageCompound(bvec->bv_page));
Yes, like that modulo the fix in your reply and any other fixes.
| |