Messages in this thread | | | Subject | Re: [PATCH] regulator: pca9450: Fix return value when failing to get sd-vsel GPIO | From | Frieder Schrempf <> | Date | Mon, 22 Feb 2021 16:16:06 +0100 |
| |
On 22.02.21 16:08, Schrempf Frieder wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > This fixes the return value of pca9450_i2c_probe() to use the correct > error code when getting the sd-vsel GPIO fails. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Sorry, I just noticed, that the PR for v5.12 was already sent, but I think not yet pulled by Linus. So I probably should have waited for this to happen and added a proper Fixes tag. I guess I will just resend after the faulty patch found its way into Linus' tree.
> --- > drivers/regulator/pca9450-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c > index d38109cc3a01..2f7ee212cb8c 100644 > --- a/drivers/regulator/pca9450-regulator.c > +++ b/drivers/regulator/pca9450-regulator.c > @@ -822,7 +822,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c, > > if (IS_ERR(pca9450->sd_vsel_gpio)) { > dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n"); > - return ret; > + return PTR_ERR(pca9450->sd_vsel_gpio); > } > > dev_info(&i2c->dev, "%s probed.\n", >
| |