Messages in this thread | | | Subject | Re: [PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox() | From | Tariq Toukan <> | Date | Sun, 21 Feb 2021 17:12:34 +0200 |
| |
On 2/21/2021 4:35 PM, Chuhong Yuan wrote: > mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to > free the memory region allocated by mlx4_alloc_cmd_mailbox() before > an exit. > Add the missed call to fix it. > > Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > index 394f43add85c..a99e71bc7b3c 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > @@ -4986,6 +4986,7 @@ static int mlx4_do_mirror_rule(struct mlx4_dev *dev, struct res_fs_rule *fs_rule > > if (!fs_rule->mirr_mbox) { > mlx4_err(dev, "rule mirroring mailbox is null\n"); > + mlx4_free_cmd_mailbox(dev, mailbox); > return -EINVAL; > } > memcpy(mailbox->buf, fs_rule->mirr_mbox, fs_rule->mirr_mbox_size); >
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch. Tariq
| |