Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop | Date | Sat, 20 Feb 2021 11:07:34 +0200 |
| |
Hao Chen <chenhaoa@uniontech.com> writes:
> When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't > resume. > The dmesg of kernel report: > "[ 99.990168] pcieport 0000:00:01.2: can't change power state > from D3hot to D0 (config space inaccessible) > [ 99.993334] rtw_pci 0000:01:00.0: can't change power state > from D3hot to D0 (config space inaccessible) > [ 104.435004] rtw_pci 0000:01:00.0: mac power on failed > [ 104.435010] rtw_pci 0000:01:00.0: failed to power on mac" > When try to pointer the driver.pm to NULL, the problem is fixed. > This driver hasn't implemented pm ops yet.It makes the sleep and > wake procedure expected when pm's ops not NULL.
But why rtw_pci_suspend() and rtw_pci_resume() are empty? Should we just remove them if they cause issues for the users? And if they are really needed there should be a comment in the functions explaining the situation.
> Fixed: commit e3037485c68e ("rtw88: new Realtek 802.11ac driver")
This should be:
Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |