lkml.org 
[lkml]   [2021]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support
On Fri, Feb 19, 2021 at 03:02:35PM +0100, Adrien Grassein wrote:
> Le ven. 19 févr. 2021 à 14:19, Krzysztof Kozlowski <krzk@kernel.org> a écrit :
> >
> > On Wed, Feb 17, 2021 at 05:10:47PM +0100, Adrien Grassein wrote:
> > > Add the description for espi support.
> > >
> > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 30 +++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > index f62a25efc69e..c4bb22bb4e6a 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > > @@ -10,6 +10,14 @@ / {
> > > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
> > > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
> > >
> > > + clock {
> > > + clk16m: clk16m {
> >
> > No changes here. The review tag was conditional in a way that I assumed
> > you will implement this change.
> >
> Sorry I misunderstood your comment. I renamed the "clocks" node.
> By the way, after a review, this nod is useless (not used).

The "clocks" node was okay, you can also remove it. I was commenting
below the clock itself. The device nodes should have generic names, so
"clock" or "clock-16m".

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-02-20 20:23    [W:0.109 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site