lkml.org 
[lkml]   [2021]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/swap_slots.c: remove redundant NULL check
From
Date
On 21.01.21 08:30, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing
> functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> mm/swap_slots.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/swap_slots.c b/mm/swap_slots.c
> index 0357fbe..be9de6d 100644
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
> cache->slots_ret = NULL;
> }
> spin_unlock_irq(&cache->free_lock);
> - if (slots)
> - kvfree(slots);
> + kvfree(slots);
> }
> }
>
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-02-02 11:15    [W:0.049 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site