Messages in this thread | | | From | Richard Zhu <> | Subject | RE: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie | Date | Sat, 20 Feb 2021 01:27:11 +0000 |
| |
> -----Original Message----- > From: Krzysztof Wilczyński <kw@linux.com> > Sent: Friday, February 19, 2021 1:34 AM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; helgaas@kernel.org; stefan@agner.ch; > lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de > Subject: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie > [...] > > > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register > > > length"), i.MX6QP PCIe has the similar issue. > > > Define the length of the DBI registers and limit config space to its > > > length for i.MX6QP PCIe too. > > > > You could probably flip these two sentences around to make the commit > > message read slightly better, so what about this (a suggestion): > > > > Define the length of the DBI registers and limit config space to its > > length. This makes sure that the kernel does not access registers > > beyond that point that otherwise would lead to an abort on a i.MX > 6QuadPlus. > > > > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that > > resolves a similar issue on a i.MX 6Quad PCIe. > [...] > > If you do decide to send another version, then also use "PCIe" in the subject, > rather than "pcie". I forgot to mention this in the previous message, > apologies. > [Richard Zhu] Never mind. Thanks a lot for your comments. Would issue another version a moment later.
Best Regards Richard Zhu
> Krzysztof
| |