Messages in this thread | | | From | Thiago Jung Bauermann <> | Subject | Re: [PATCH] powerpc/kexec_file: Restore FDT size estimation for kdump kernel | Date | Fri, 19 Feb 2021 20:42:16 -0300 |
| |
Lakshmi Ramasubramanian <nramas@linux.microsoft.com> writes:
> On 2/19/21 6:25 AM, Thiago Jung Bauermann wrote: > > One small nit in the function header (please see below), but otherwise the > change looks good. > > Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Thanks for your review. I incorporated your suggestion and will send v2 shortly.
>> --- a/arch/powerpc/kexec/file_load_64.c >> +++ b/arch/powerpc/kexec/file_load_64.c >> @@ -927,37 +927,27 @@ int setup_purgatory_ppc64(struct kimage *image, const void *slave_code, >> } >> /** >> - * kexec_fdt_totalsize_ppc64 - Return the estimated size needed to setup FDT >> - * for kexec/kdump kernel. >> - * @image: kexec image being loaded. >> + * kexec_extra_fdt_size_ppc63 - Return the estimated size needed to setup FDT > > Perhaps change to > > "Return the estimated additional size needed to setup FDT for kexec/kdump > kernel"?
That's better indeed. I also hadn't noticed that I changed ppc64 to ppc63. Fixed as well.
-- Thiago Jung Bauermann IBM Linux Technology Center
| |