Messages in this thread | | | Date | Fri, 19 Feb 2021 20:14:32 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning |
| |
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote: > > > changes since previous version: > - change Subject line > - change commit message > - change commit message position to above signed-off-by >
These comments need to go below the --- cut off line.
> checkpatch gives the following WARNING: > WARNING: Comparisons should place the constant on the right side of the test > this patch fixes the coding style warning. > > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- ^^^
This one here.
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
regards, dan carpenter
| |