Messages in this thread | | | Date | Fri, 19 Feb 2021 16:48:57 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v4 1/4] PCI: Introduce pcim_alloc_irq_vectors() |
| |
On Fri, Feb 19, 2021 at 03:40:05PM +0100, Robert Richter wrote: > On 18.02.21 23:04:55, Dejin Zheng wrote: > > Introduce pcim_alloc_irq_vectors(), a device-managed version of > > pci_alloc_irq_vectors(). Introducing this function can simplify > > the error handling path in many drivers. > > > > And use pci_free_irq_vectors() to replace some code in pcim_release(), > > they are equivalent, and no functional change. It is more explicit > > that pcim_alloc_irq_vectors() is a device-managed function.
...
> If it is just about having a pcim-* counterpart why not just an inline > function like the one below.
It's a good suggestion, thanks!
Still we need to amend pcim_release() to explicitly show that we call pci_free_irq_vectors().
-- With Best Regards, Andy Shevchenko
| |