lkml.org 
[lkml]   [2021]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames
On Thu, Feb 18, 2021 at 12:06 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > This is how we write code, we use defines instead of constant numbers,
> > comments to describe tricky parts and assign already preprocessed result.
> >
> > There is nothing I can do If you don't like or don't want to use Linux kernel
> > style.
>
> So what is your suggestion exactly? Use defines or write comments?
>
> As I understand, you want to replace the "3 - 1" with "2", and then
> write comments to explain that this "2" is the result of "3 - 1".
>
> Why do you want to do this? You are doing useless things and you force
> readers of this code to think about useless things.
>
> You said this was "Linux kernel style"? Why? Which sentence of the
> Linux kernel style guide suggests your way is better than my way?

Nevermind, if you *really* want me to replace this "3 - 1" with "2"
and explain in the comment that the "2" is a result of "3 - 1". I'll
do this. I admit this is a style issue. So it is hard to argue and
reach an agreement. Just reply with a request and I'll make the
change. However I'm not able to agree with you in my heart.

On Thu, Feb 18, 2021 at 12:06 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > This is how we write code, we use defines instead of constant numbers,
> > comments to describe tricky parts and assign already preprocessed result.
> >
> > There is nothing I can do If you don't like or don't want to use Linux kernel
> > style.
>
> So what is your suggestion exactly? Use defines or write comments?
>
> As I understand, you want to replace the "3 - 1" with "2", and then
> write comments to explain that this "2" is the result of "3 - 1".
>
> Why do you want to do this? You are doing useless things and you force
> readers of this code to think about useless things.
>
> You said this was "Linux kernel style"? Why? Which sentence of the
> Linux kernel style guide suggests your way is better than my way?

\
 
 \ /
  Last update: 2021-02-18 21:25    [W:0.060 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site