lkml.org 
[lkml]   [2021]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH
From
Date
Thanks Daniel and Willem!

So sorry to reply to you late for I just took the Chinese Spring Festival vacation.

I will resubmit this patch.

Thanks again!

> 2021年2月11日 下午11:26,Daniel Borkmann <daniel@iogearbox.net> 写道:
>
> On 2/10/21 3:50 PM, Willem de Bruijn wrote:
>> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen <hxseverything@gmail.com> wrote:
>>>
>>> From: huangxuesen <huangxuesen@kuaishou.com>
>>>
>>> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
>>> encapsulation. But that is not appropriate when pushing Ethernet header.
>>>
>>> Add an option to further specify encap L2 type and set the inner_protocol
>>> as ETH_P_TEB.
>>>
>>> Suggested-by: Willem de Bruijn <willemb@google.com>
>>> Signed-off-by: huangxuesen <huangxuesen@kuaishou.com>
>>> Signed-off-by: chengzhiyong <chengzhiyong@kuaishou.com>
>>> Signed-off-by: wangli <wangli09@kuaishou.com>
>> Thanks, this is exactly what I meant.
>> Acked-by: Willem de Bruijn <willemb@google.com>
>> One small point regarding Signed-off-by: It is customary to capitalize
>> family and given names.
>
> +1, huangxuesen, would be great if you could resubmit with capitalized names in
> your SoB as well as From (both seem affected).
>
> Thanks,
> Daniel

\
 
 \ /
  Last update: 2021-02-18 19:51    [W:0.064 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site