lkml.org 
[lkml]   [2021]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH] drm/tilcdc: fix raster control register setting
On 2021-02-16 22:22, Dario Binacchi wrote:
> The fdd property of the tilcdc_panel_info structure must set the reqdly
> bit field (bit 12 to 19) of the raster control register. The previous
> statement set the least significant bit instead.
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>

Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Tested-by: Jyri Sarha <jyri.sarha@iki.fi>

Thanks for a good catch. I'll merge to this drm-misc-next soon.

Best regards,
Jyri

>
> ---
>
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 30213708fc99..238068e28729 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc
> *crtc)
> return;
> }
> }
> - reg |= info->fdd < 12;
> + reg |= info->fdd << 12;
> tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg);
>
> if (info->invert_pxl_clk)

\
 
 \ /
  Last update: 2021-02-18 19:31    [W:0.036 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site