Messages in this thread Patch in this message | | | Date | Thu, 18 Feb 2021 19:04:20 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 |
| |
Fix the subject. Don't mention eudyptula.
[PATCH] Staging: rtl8723bs: put constant on right side of comparison
Add a commit message:
Checkpatch complains that the constant needs to be on the right hand side of the comparion.
On Thu, Feb 18, 2021 at 03:54:40PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index 975f2830e29e..089c6ec19373 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) > struct security_priv *psecpriv = &padapter->securitypriv; > > memset(pcur_dot11txpn, 0, 8); > - if (NULL == StaAddr) > + if (StaAddr == NULL)
The prefered format for this is actually:
if (!StaAddr) return;
regards, dan carpenter
| |