Messages in this thread | | | Date | Thu, 18 Feb 2021 08:28:27 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 3/8] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy() |
| |
On Thu, Feb 18, 2021 at 08:24:23AM +0000, Nadav Amit wrote: > In general, thanks for the feedback (I will reply after I follow your > feedback). I do have a general question - I thought it was decided that > clarity should be preferred over following the 80-column limit. Please let > me know if I misunderstood.
To quote the coding style document:
"The preferred limit on the length of a single line is 80 columns.
Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information."
While a lot of the decisions are subjective, just spilling over for no good reason does not significantly improve readability in general.
| |