lkml.org 
[lkml]   [2021]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 1/8] smp: Run functions concurrently in smp_call_function_many_cond()
    On Tue, Feb 09, 2021 at 02:16:46PM -0800, Nadav Amit wrote:
    > +/*
    > + * Flags to be used as scf_flags argument of smp_call_function_many_cond().
    > + */
    > +#define SCF_WAIT (1U << 0) /* Wait until function execution completed */
    > +#define SCF_RUN_LOCAL (1U << 1) /* Run also locally if local cpu is set in cpumask */

    Can you move the comments on top of the defines to avoid the crazy
    long lines?

    > + if (cpu_online(this_cpu) && !oops_in_progress && !early_boot_irqs_disabled)

    Another pointlessly overly long line, with various more following.

    > EXPORT_SYMBOL(on_each_cpu_cond_mask);

    This isn't used by any modular code, so maybe throw in a patch to drop
    the export?

    \
     
     \ /
      Last update: 2021-02-18 10:24    [W:2.503 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site