lkml.org 
[lkml]   [2021]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] tpm: fix reference counting for struct tpm_chip
On Tue, Feb 16, 2021 at 04:31:26PM +0000, David Laight wrote:
> ...
> > > > + get_device(&chip->dev);
> > > > + chip->devs.release = tpm_devs_release;
> > > > + chip->devs.devt =
> > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES);
> >
> > Isn't this less than 100 chars?
>
> Still best kept under 80 if 'reasonable'?
>
> Really it is just split in the wrong place:
> chip->devs.devt = MKDEV(MAJOR(tpm_devt),
> chip->dev_num + TPM_NUM_DEVICES);


Well it looks crap IMHO. Would be more reasonable to have it in a single
like. And it is legit too, since it is accepted by checkpatch.

You might break the lines within 80 chars if it is somehow "logically"
consistent.

>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
>

/Jarkko

\
 
 \ /
  Last update: 2021-02-17 23:16    [W:0.093 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site