Messages in this thread | | | Subject | Re: [PATCH][next] ASoC: codecs: lpass-rx-macro: remove redundant initialization of variable hph_pwr_mode | From | Srinivas Kandagatla <> | Date | Wed, 17 Feb 2021 14:14:51 +0000 |
| |
On 15/02/2021 20:05, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable hph_pwr_mode is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Thanks for the patch!
LGTM,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> sound/soc/codecs/lpass-rx-macro.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c > index 8c04b3b2c907..76909c50d7b9 100644 > --- a/sound/soc/codecs/lpass-rx-macro.c > +++ b/sound/soc/codecs/lpass-rx-macro.c > @@ -2038,7 +2038,7 @@ static int rx_macro_load_compander_coeff(struct snd_soc_component *component, > { > u16 comp_coeff_lsb_reg, comp_coeff_msb_reg; > int i; > - int hph_pwr_mode = HPH_LOHIFI; > + int hph_pwr_mode; > > if (!rx->comp_enabled[comp]) > return 0; >
| |