lkml.org 
[lkml]   [2021]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash
On Wed, Feb 17, 2021 at 12:19:43PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@akkea.ca>
>
> These sections should be read only as they contain important data.
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..3c0462f81b3a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;

Still a line break here is needed.

> + partition@0 {
> + label = "protected0";
> + reg = <0x00000000 0x00030000>;
> + read-only;
> + };
> + partition@30000 {
> + label = "protected1";
> + reg = <0x00030000 0x00010000>;

Drop the leading 0 in address and size. I saw some DTS using it but it's
not the common format. All nodes don't lead with 0 so why partitions are
different?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-02-17 13:00    [W:0.064 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site