lkml.org 
[lkml]   [2021]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices
    Date
    Srinivasan Raju <srini.raju@purelifi.com> writes:

    > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
    > and LiFi-XL USB devices.
    >
    > This driver implementation has been based on the zd1211rw driver.
    >
    > Driver is based on 802.11 softMAC Architecture and uses
    > native 802.11 for configuration and management.
    >
    > The driver is compiled and tested in ARM, x86 architectures and
    > compiled in powerpc architecture.
    >
    > Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>

    [...]

    > + send_vendor_command(udev, PLF_VNDR_FPGA_STATE_CMD, NULL, 0);
    > +
    > + msleep(200);

    There are multiple msleeps like this, please add a descriptive define
    for value 200.

    --
    https://patchwork.kernel.org/project/linux-wireless/list/

    https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

    \
     
     \ /
      Last update: 2021-02-17 11:39    [W:4.387 / U:0.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site