Messages in this thread | | | Date | Tue, 16 Feb 2021 21:18:00 +0530 | From | Kumar Kartikeya Dwivedi <> | Subject | Re: [PATCH 02/13] staging: greybus: Switch from strlcpy to strscpy |
| |
On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote: > This is a good change. But while you're at it, I would > appreciate if you would convert a few spots to use > sizeof(dest) rather than a fixed constant. I will > point them out below. > > If this is the *only* request for a change on your > series, please tell me that and I can sign off on
So far, this has been the only request.
> this without you implementing my suggestion. But > if you post a version 2, please do what I describe. >
I will incorporate these if I end up sending a v2.
Alternatively, would a separate patch with your suggestions applied on top of this be acceptable, if I don't?
-- Kartikeya
| |