Messages in this thread | | | From | Tobias Schramm <> | Subject | Re: [PATCH] Add CHARGE_NOW support to cw2015_battery.c | Date | Tue, 16 Feb 2021 16:30:50 +0100 |
| |
Hi Martin,
> > thanks for the patch. Looks good and tests fine. > eh, scratch that. Didn't have my cup of morning coffee yet. The patch is fine as far as the code change goes. However it is missing a "Signed-off-by" line, certifying your authorship. git can generate that automagically for you with `git commit --signoff`.
>> CHARGE_NOW is expected by some user software (such as waybar) >> instead of 'CAPACITY', in order to correctly calculate >> remaining battery life. >> There needs to be a "Signed-off-by" line right here. >> --- >> drivers/power/supply/cw2015_battery.c | 6 ++++++ >> 1 file changed, 6 insertions(+) [ ... ] > > Reviewed-by: Tobias Schramm <t.schramm@manjaro.org> Review retracted.
Please resend the patch with the "Signed-off-by" line included. Then I can mark it as reviewed.
Sorry for the confusion,
Tobias Schramm
| |