lkml.org 
[lkml]   [2021]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Add CHARGE_NOW support to cw2015_battery.c
Date
Hi Martin,

>
> thanks for the patch. Looks good and tests fine.
>
eh, scratch that. Didn't have my cup of morning coffee yet. The patch is
fine as far as the code change goes. However it is missing a
"Signed-off-by" line, certifying your authorship. git can generate that
automagically for you with `git commit --signoff`.

>> CHARGE_NOW is expected by some user software (such as waybar)
>> instead of 'CAPACITY', in order to correctly calculate
>> remaining battery life.
>>
There needs to be a "Signed-off-by" line right here.
>> ---
>>   drivers/power/supply/cw2015_battery.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
[ ... ]
>
> Reviewed-by: Tobias Schramm <t.schramm@manjaro.org>
Review retracted.

Please resend the patch with the "Signed-off-by" line included. Then I
can mark it as reviewed.


Sorry for the confusion,

Tobias Schramm

\
 
 \ /
  Last update: 2021-02-17 11:37    [W:0.030 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site