lkml.org 
[lkml]   [2021]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()
From
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 15 Feb 2021 18:56:46 +0300

> The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX".
>
> I did some cleanup in this function to hopefully make the code a bit
> clearer. There was no blank line after the declaration block. The
> closing curly brace on the fec[] declaration normally goes on a line
> by itself. And I removed the FEC_MAX_INDEX define and used
> ARRAY_SIZE(fec) instead.
>
> Fixes: d0cf9503e908 ("octeontx2-pf: ethtool fec mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

This doesn't apply to net-next.

\
 
 \ /
  Last update: 2021-02-15 21:59    [W:0.148 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site