Messages in this thread | | | Subject | Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()' | From | Jan Kiszka <> | Date | Mon, 15 Feb 2021 14:42:42 +0100 |
| |
On 15.02.21 14:22, Andy Shevchenko wrote: > On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote: >> Call to 'pci_free_irq_vectors()' are missing both in the error handling >> path of the probe function, and in the remove function. So add them. > > I'm wondering if you noticed that it's done by pcim_* API. > Perhaps you can introduce pcim_alloc_irq_vectors() or so and do not add these > calls at all?
You mean as plain wrapper for pci_alloc_irq_vectors, just to document it's managed?
> >> Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI") > > No, it doesn't fix anything. >
Ah, now I recall: imbalanced APIs.
Jan
-- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux
| |