Messages in this thread | | | Date | Mon, 15 Feb 2021 15:28:48 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place |
| |
On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote: > On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote: > > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > > for simplify the code.
FYI, you may rather to introduce a pcim_alloc_irq_vectors() and drop all these calls altogether.
Note to everybody: PCIm is not ideal, but this piece is being called whenever pcim_enable_device() makes resources manageable. The problem here is the naming.
-- With Best Regards, Andy Shevchenko
| |