Messages in this thread | | | Date | Mon, 15 Feb 2021 13:49:57 +0900 | From | Nobuhiro Iwamatsu <> | Subject | Re: [PATCH v2 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver |
| |
Hi,
On Sun, Feb 14, 2021 at 08:23:25AM +0200, Leon Romanovsky wrote: > On Fri, Feb 12, 2021 at 11:58:04AM +0900, Nobuhiro Iwamatsu wrote: > > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > > This patch contains only the basic function of the device. There is no > > clock control, PM, etc. yet. These will be added in the future. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > --- > > drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 + > > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > > .../ethernet/stmicro/stmmac/dwmac-visconti.c | 288 ++++++++++++++++++ > > 3 files changed, 297 insertions(+) > > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > > index 53f14c5a9e02..55ba67a550b9 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > > @@ -219,6 +219,14 @@ config DWMAC_INTEL_PLAT > > This selects the Intel platform specific glue layer support for > > the stmmac device driver. This driver is used for the Intel Keem Bay > > SoC. > > + > > +config DWMAC_VISCONTI > > + bool "Toshiba Visconti DWMAC support" > > + def_bool y > > Doesn't it need to be "default y"? >
Indeed. I will remove this.
Thanks.
Best regards, Nobuhiro
| |