Messages in this thread | | | Subject | Re: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy | From | Perry Yuan <> | Date | Sun, 14 Feb 2021 15:23:46 +0800 |
| |
Hi Randy.
On 2021/1/13 1:39, Randy Dunlap wrote: > On 1/12/21 9:17 AM, Perry Yuan wrote: >> +config DELL_PRIVACY >> + tristate "Dell Hardware Privacy Support" >> + depends on ACPI >> + depends on ACPI_WMI >> + depends on INPUT >> + depends on DELL_LAPTOP >> + depends on LEDS_TRIGGER_AUDIO >> + select DELL_WMI >> + help >> + This driver provides support for the "Dell Hardware Privacy" feature >> + of Dell laptops. >> + Support for a micmute and camera mute privacy will be provided as >> + hardware button Ctrl+F4 and Ctrl+F9 hotkey > > End above with a period '.' please. > >> + >> + To compile this driver as a module, choose M here: the module will >> + be called dell_privacy. > > Please follow coding-style for Kconfig files: > > from Documentation/process/coding-style.rst, section 10): > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different. Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. > > > thanks. >
Thank you for the review. Format checked again and will be updated in V4.
| |