Messages in this thread | | | Date | Sun, 14 Feb 2021 03:18:49 +0100 | Subject | Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done() | From | Michael Walle <> |
| |
Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean <olteanv@gmail.com>: >Hi Michael, > >On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote: >> at803x_aneg_done() checks if auto-negotiation is completed on the >SGMII >> side. This doesn't take the mdio bus lock and the page switching is >> open-coded. Now that we have proper page support, just use >> phy_read_paged(). Also use phydev->interface to check if we have an >> SGMII link instead of reading the mode register and be a bit more >> precise on the warning message. >> >> Signed-off-by: Michael Walle <michael@walle.cc> >> --- > >How did you test this patch?
I'm afraid it's just compile time tested.
-michael
| |