Messages in this thread | | | Date | Fri, 12 Feb 2021 09:16:08 +0000 | From | Lee Jones <> | Subject | Re: [PATCH RESEND] regulator: bd718x7, bd71828, Fix dvs voltage levels |
| |
On Fri, 12 Feb 2021, Matti Vaittinen wrote:
> The ROHM BD718x7 and BD71828 drivers support setting HW state > specific voltages from device-tree. This is used also by various > in-tree DTS files. > > These drivers do incorrectly try to compose bit-map using enum > values. By a chance this works for first two valid levels having > values 1 and 2 - but setting values for the rest of the levels > do indicate capability of setting values for first levels as > well. Luckily the regulators which support setting values for > SUSPEND/LPSR do usually also support setting values for RUN > and IDLE too - thus this has not been such a fatal issue. > > Fix this by defining the old enum values as bits and fixing the > parsing code. This allows keeping existing IC specific drivers > intact and only slightly changing the rohm-regulator.c > > Fixes: 21b72156ede8b ("regulator: bd718x7: Split driver to common and bd718x7 specific parts") > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > I just noticed this fix never made it in-tree. So this is a resend of a > resend :)
Not sure what you mean. Isn't this patch part of:
[PATCH v2 00/17] Support ROHM BD71815 PMIC
... which has just been reviewed and is awaiting rework?
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |