Messages in this thread | | | Date | Fri, 12 Feb 2021 14:39:26 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c |
| |
On 12-02-21, 13:48, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > --- > drivers/staging/greybus/hid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > index ed706f39e87a..a56c3fb5d35a 100644 > --- a/drivers/staging/greybus/hid.c > +++ b/drivers/staging/greybus/hid.c > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > } > > static int __gb_hid_get_raw_report(struct hid_device *hid, > - unsigned char report_number, __u8 *buf, size_t count, > - unsigned char report_type) > + unsigned char report_number, __u8 *buf, size_t count, > + unsigned char report_type) > { > struct gb_hid *ghid = hid->driver_data; > int ret;
I can't even count the number of attempts we have seen in previous years to make checkpatch --strict happy for greybus.
I say we make this change once and for all across greybus, so we don't have to review or NAK someone afterwards.
Should I send a patch for this ?
-- viresh
| |