Messages in this thread | ![/](/images/icornerl.gif) | | From | Nobuhiro Iwamatsu <> | Date | Fri, 12 Feb 2021 08:18:19 +0900 | Subject | Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE) |
| |
Hi,
Thanks for your review.
2021年2月1日(月) 19:08 Michal Simek <michal.simek@xilinx.com>: > > Hi, > > On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote: > > zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx: > > Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE). > > This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also > > modify the documentation for this driver. > > > > Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs") > > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > > --- > > Documentation/driver-api/xilinx/eemi.rst | 27 +----------------------- > > include/linux/firmware/xlnx-zynqmp.h | 5 ----- > > 2 files changed, 1 insertion(+), 31 deletions(-) > > > > diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst > > index 9dcbc6f18d75df..53416d25d309a8 100644 > > --- a/Documentation/driver-api/xilinx/eemi.rst > > +++ b/Documentation/driver-api/xilinx/eemi.rst > > @@ -19,32 +19,7 @@ device to issue or respond to power management requests. > > EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC. > > The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops > > structure. Any driver who want to communicate with PMC using EEMI APIs > > The whole paragraph should be tuned. I would leave here just > > "Any driver who want to communicate with PMC using EEMI APIs > use the functions provided for each function." > > Because there is no reference to any eemi ops structure. > > The rest looks good to me.
Thank you. I will add your point to the commit log and resend. Best regards, Nobuhiro
-- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6
| ![\](/images/icornerr.gif) |