Messages in this thread | | | From | Shengjiu Wang <> | Date | Wed, 10 Feb 2021 14:35:29 +0800 | Subject | Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg |
| |
On Wed, Feb 10, 2021 at 6:30 AM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Feb 09, 2021 at 05:16:16PM +0800, Shengjiu Wang wrote: > > On Mon, Feb 8, 2021 at 7:53 PM Mark Brown <broonie@kernel.org> wrote: > > > > hw_params() can be called multiple times and there's no need for it to > > > be balanced with hw_free(), I'd move this to a different callback (DAPM > > > should work well). > > > Which callback should I use? Is there an example? > > Like I say I'd actually recommend moving this control to DAPM.
I may understand your point, you suggest to use the .set_bias_level interface. But in my case I need to enable the clock in earlier stage and keep the clock on when system go to suspend.
I am not sure .set_bias_level can met my requirement. we start the Chinese new year holiday now, so currently I can't do test for this recommendation.
Maybe we can keep current implementation, can we? Later after I do the test, I can submit another patch for it.
Best regards Wang Shengjiu
| |