Messages in this thread | | | Date | Wed, 10 Feb 2021 12:20:02 +0100 | From | Michael Walle <> | Subject | Re: [PATCH net-next] net: phy: introduce phydev->port |
| |
Am 2021-02-09 17:38, schrieb Michael Walle: > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -308,7 +308,7 @@ void phy_ethtool_ksettings_get(struct phy_device > *phydev, > if (phydev->interface == PHY_INTERFACE_MODE_MOCA) > cmd->base.port = PORT_BNC; > else > - cmd->base.port = PORT_MII; > + cmd->base.port = phydev->port; > cmd->base.transceiver = phy_is_internal(phydev) ? > XCVR_INTERNAL : XCVR_EXTERNAL; > cmd->base.phy_address = phydev->mdio.addr;
Russell, the phylink has a similiar place where PORT_MII is set. I don't know if we'd have to change that, too.
Also, I wanted to look into the PHY_INTERFACE_MODE_MOCA thing and if we can get rid of the special case here and just set phydev->port to PORT_BNC in the driver. Florian, maybe you have a comment on this?
-michael
| |