Messages in this thread | | | Date | Wed, 10 Feb 2021 22:19:08 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 1/2] Revert "MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes" |
| |
On Wed, Feb 10, 2021 at 07:11:00PM +0000, Christoph Hellwig wrote: > On Wed, Feb 10, 2021 at 05:16:13PM +0100, Thomas Bogendoerfer wrote: > > This reverts commit 6ebda44f366478d1eea180d93154e7d97b591f50. > > > > All icache flushes in this code paths are done via flush_icache_range(), > > which only uses normal cache instruction. And this is the correct thing > > for EVA mode, too. So no need to do set_fs(KERNEL_DS) here. > > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > ... it might be time to kill off the remaining set_fs() users in mips > code as well ...
I already have patches for that. Still needs some cleaning and testing before sending/applying it.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |