Messages in this thread | | | Subject | Re: [PATCH 5/5] KVM: x86/xen: Explicitly pad struct compat_vcpu_info to 64 bytes | From | "Woodhouse, David" <> | Date | Wed, 10 Feb 2021 21:20:08 +0000 |
| |
On Wed, 2021-02-10 at 13:13 -0800, Sean Christopherson wrote: > On Wed, Feb 10, 2021, Woodhouse, David wrote: > > On Wed, 2021-02-10 at 10:26 -0800, Sean Christopherson wrote: > > So it isn't clear the additionally padding really buys us anything; if > > we play this game without knowing the ABI we'd be screwed anyway. But > > it doesn't hurt. > > Ya, this is purely for folks reading the code and wondering how 62==64.
Fair enough. That kind of thing is why I littered the code with assertions based on sizeof() and offsetof() :)
Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
| |