Messages in this thread | | | Subject | Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h | From | Waiman Long <> | Date | Wed, 10 Feb 2021 13:50:45 -0500 |
| |
On 2/10/21 1:28 PM, Paolo Bonzini wrote: > On 10/02/21 15:45, Waiman Long wrote: >> The queued rwlock code has a dependency on the current spinlock >> implementation (likely to be qspinlock), but not vice versa. Including >> qrwlock.h before qspinlock.h can be problematic when expanding qrwlock >> functionality. >> >> If both qspinlock.h and qrwlock.h are to be included, the qrwlock.h >> include should always be after qspinlock.h. Update the current set of >> asm/spinlock.h files to enforce that. >> >> Signed-off-by: Waiman Long <longman@redhat.com> > > arch/sparc/include/asm/spinlock_64.h is missing. Also, the include in > kernel/locking/qrwlock.c is not necessary (it may be there for > aesthetic reasons, but it complicates thing in this case).
Sorry for missing arch/sparc/include/asm/spinlock_64.h. I was just focusing on asm/spinlock.h and not aware that there are other variants there.
It is true that the asm/qrwlock.h include in qrwlock.c is not really necessary. I can't recall why it was there.
> > I'll send a v2 that is based on the kvm/next tree. > > Paolo > Thanks for taking care of that.
Cheers, Longman
| |