| Subject | Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered | From | Vlastimil Babka <> | Date | Wed, 10 Feb 2021 19:23:43 +0100 |
| |
On 2/9/21 6:46 PM, Yang Shi wrote: > Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. > This approach is fine with nr_deferred at the shrinker level, but the following > patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their > shrinker->nr_deferred would always be NULL. This would prevent the shrinkers > from unregistering correctly. > > Remove SHRINKER_REGISTERING since we could check if shrinker is registered > successfully by the new flag. > > Acked-by: Kirill Tkhai <ktkhai@virtuozzo.com> > Signed-off-by: Yang Shi <shy828301@gmail.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
With Roman's suggestion it's fine by me too.
|